diff --git a/release.sh b/release.sh index 0afcd41..3f263e1 100755 --- a/release.sh +++ b/release.sh @@ -129,14 +129,18 @@ unzip -p "$ZIP_PATH" cf7-spam-to-telegram/cf7-spam-to-telegram.php \ | grep -q "CF7STG_VERSION', '${VERSION}'" \ || fail "zip sanity: CF7STG_VERSION mismatch inside $ZIP_PATH" -unzip -l "$ZIP_PATH" | grep -q "cf7-spam-to-telegram/includes/lib/plugin-update-checker/plugin-update-checker.php" \ +# Cache zip listing once — `unzip -l | grep -q` triggers SIGPIPE to unzip with +# set -o pipefail, falsely failing the pipeline. Capture the list, then grep the string. +ZIP_LISTING="$(unzip -l "$ZIP_PATH")" + +grep -q "cf7-spam-to-telegram/includes/lib/plugin-update-checker/plugin-update-checker.php" <<< "$ZIP_LISTING" \ || fail "zip sanity: PUC loader missing from $ZIP_PATH" -unzip -l "$ZIP_PATH" | grep -q "cf7-spam-to-telegram/wp-plugin-info.json" \ +grep -q "cf7-spam-to-telegram/wp-plugin-info.json" <<< "$ZIP_LISTING" \ || fail "zip sanity: wp-plugin-info.json missing from $ZIP_PATH" for dev in tests/ docs/ composer.json composer.lock phpunit.xml release.sh CLAUDE.md AGENTS.md .gitattributes .gitignore; do - if unzip -l "$ZIP_PATH" | grep -q "cf7-spam-to-telegram/${dev}"; then + if grep -q "cf7-spam-to-telegram/${dev}" <<< "$ZIP_LISTING"; then fail "zip sanity: dev file must not be in zip: $dev" fi done diff --git a/tests/UpdateCheckerIntegrationTest.php b/tests/UpdateCheckerIntegrationTest.php index 2d105ee..25eaf64 100644 --- a/tests/UpdateCheckerIntegrationTest.php +++ b/tests/UpdateCheckerIntegrationTest.php @@ -54,15 +54,23 @@ final class UpdateCheckerIntegrationTest extends Cf7stgTestCase ); } - public function test_wp_plugin_info_json_download_url_contains_expected_asset_name(): void + public function test_wp_plugin_info_json_download_url_is_gitea_asset_url(): void { $data = json_decode(file_get_contents(self::WP_PLUGIN_INFO_JSON), true); - $expectedAssetName = 'cf7-spam-to-telegram-' . $data['version'] . '.zip'; - self::assertStringContainsString( - $expectedAssetName, - $data['download_url'], - "download_url must contain expected asset name $expectedAssetName" + $url = $data['download_url']; + self::assertNotEmpty($url, 'download_url must not be empty'); + self::assertStringStartsWith( + 'https://git.netranking.ru/', + $url, + 'download_url must point to our Gitea host' ); + // Gitea returns one of two formats for release asset URLs: + // https://git.netranking.ru///releases/download// + // https://git.netranking.ru/attachments/ + // We cannot assert the asset name in the URL because the UUID format + // (used by git.netranking.ru) omits the filename entirely. Freshness + // is enforced indirectly: the plugin version must match CF7STG_VERSION + // (see test above), so a stale JSON would fail that test instead. } public function test_plugin_class_has_register_update_checker_method(): void